[POWEROPS-2558] chore: linters and codecov in workflows #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
nodegard
changed the title
eriklien
approved these changes
Aug 8, 2024
Comment on lines
+59
to
+62
| SETTINGS__COGNITE__CLIENT_ID: ${{ vars.CLIENT_ID }} | ||
| SETTINGS__COGNITE__PROJECT: ${{ vars.PROJECT }} | ||
| SETTINGS__COGNITE__CDF_CLUSTER: ${{ vars.CLUSTER }} | ||
| SETTINGS__COGNITE__TENANT_ID: ${{ vars.TENANT_ID }} |
There was a problem hiding this comment.
question: Is this pointing to environment variables in the CI environment? I don't see them there.
There was a problem hiding this comment.
They're on the repo level because all the envs need them
Comment on lines
-11
to
-30
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.9" | ||
|
|
||
| # The installation is required as mypy must be run in the local system environment, not in the pre-commit environment. | ||
| - name: Install required dependencies | ||
| run: | | ||
| python3 -m pip install --upgrade pip poetry | ||
| poetry config virtualenvs.create false | ||
| poetry install | ||
|
|
||
| - name: Linting and static code checks | ||
| run: | | ||
| pre-commit run --all-files | ||
|
|
There was a problem hiding this comment.
question: Not needed here because we do it in build.yml?
There was a problem hiding this comment.
Yea, no need to re-run pre-commit on merge to main given the branch protections and strict requirements for passing on PRs toward main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist: